Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator boot stub for SRAM added #361

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

marnovandermaas
Copy link
Contributor

This boot stub is useful for SRAM only examples like the ones in the current upstream RTOS.

Copy link
Contributor

@AlexJones0 AlexJones0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as mentioned might be worth adding a comment and maybe even defining the 0x00101000 immediate (e.g. #define SRAM_BASE 0x00101000) so that it is easier to parse what is happening. If you rebase your PR on main it should pass CI now.

This does not have any functional changes, just removes some tabs and
defines HYPERRAM_BASE for readability
@marnovandermaas marnovandermaas merged commit 658a741 into lowRISC:main Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants