Allow copying symlinks as links, rather than copying the target

[jamesrtnz]

All submissions

• I have followed the Contributing Guidelines
• I have checked to ensure there aren't other open Pull Requests for the same update/change

Improving the Mackup codebase

• My submission passes the tests
• I have linted the code locally prior to submission
• I have written new tests as applicable
• I have added an explanation of what the changes do

[lra]

What problem is being solved here? Any concrete example? This seems to change the whole behavior of Mackup for a specific issue.

[jamesrtnz]

Hi,

To be honest, as it's been a while since I created the PR, I'm not 100% sure what my driver was. The functionality being implemented was useful to me personally, and I thought it might be useful for others too.

I think the rationale was I had file(s) like bash profile etc that were actually stored in GIT source control, and symlinked to their required location (for example, .bash_profile -> ~/GIT/jrt-profile/bash_profile), and I wanted Mackup to backup/store the link rather than the actual source file.

Partially the PR was raised as a personal learning exercise; especially around the unit test functionality etc.

I agree that as a global change this may be a bit OTT, but I don't know enough Python to work out how to implement the configuration setting on a per-app basis.

[lra]

Ok thanks, let's close this as I don't know what to do with it. You are free to iterate though, closing != deleting.