-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Remove Course Management and Admin modules
#10184
base: develop
Are you sure you want to change the base?
Development
: Remove Course Management and Admin modules
#10184
Conversation
Development
: Remove Course Management client modulesDevelopment
: Remove Course Management/LTI modules
# Conflicts: # src/main/webapp/app/course/dashboards/assessment-dashboard/assessment-dashboard.module.ts # src/main/webapp/app/course/tutorial-groups/tutorial-groups-management/tutorial-groups-management.module.ts # src/main/webapp/app/exam/participate/summary/exam-result-summary.module.ts # src/main/webapp/app/exercises/shared/dashboards/tutor/exercise-assessment-dashboard.module.ts # src/main/webapp/app/exercises/shared/participation/participation.module.ts # src/main/webapp/app/grading-system/grading-system.module.ts
cd1f610
to
a4598d7
Compare
# Conflicts: # src/main/webapp/app/exam/manage/exam-management.module.ts # src/main/webapp/app/exam/participate/summary/exam-result-summary.module.ts
# Conflicts: # jest.config.js
8d10abd
This reverts commit 46e0b84.
Development
: Remove Course Management/LTI modulesDevelopment
: Remove Course Management modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. Everything works as expected!
3242aaa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove
Everything works as expected! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approve code after merge conflict was resolved
Development
: Remove Course Management modulesDevelopment
: Remove Course Management and Admin modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3, all works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS5, all mentioned points work as expected 👍
Checklist
General
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
We want to remove all ngModules step by step to completely follow modern Angular best practices without modules and standalone components instead. This ensures the long-term maintainability of the Artemis client application.
Description
Removed all modules related to course management and LTI and adapted routes as necessary.
Steps for Testing
Prerequisites:
Exam Mode Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
changed files only affect routes and modules. For those files, coverage is not a suitable metric.
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Refactor
Chores