Development: Fix failing LearningPathIntegrationTests

[N0W0RK]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

After changes to caching behavior the LearningPathIntegrationIntegrationTests led to invalid database states violating foreign key constraints.

Description

Fixed caching behaviour

Steps for Testing

Prerequisites:

• Check, that all relevant server Tests pass.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

• Code Review 1

Summary by CodeRabbit

• Refactor
  • Removed caching strategy for course learner profiles
• Chores
  • Updated instruction coverage threshold for the atlas module

[coderabbitai]

Walkthrough

The pull request involves a modification to the LearnerProfile class in the Artemis Atlas domain. Specifically, the @Cache annotation with the NONSTRICT_READ_WRITE strategy has been removed from the courseLearnerProfiles field. This change alters the caching strategy for the collection of course learner profiles, removing the explicit caching configuration while maintaining the field's basic structure and initialization. Additionally, the instruction coverage threshold for the atlas module in the jacoco.gradle file has been adjusted from 0.860 to 0.850.

Changes

File	Change Summary
src/main/java/de/tum/cit/aet/artemis/atlas/domain/profile/LearnerProfile.java	Removed @Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE) annotation from courseLearnerProfiles field
gradle/jacoco.gradle	Changed INSTRUCTION coverage threshold for atlas module from 0.860 to 0.850

Possibly related PRs

• Development: Fix LTI urls #8998: This PR modifies URL constructions in the CustomLti13Configurer.java and related classes, which may be indirectly related to the caching strategy change in LearnerProfile.java as both involve LTI functionality.
• Development: Fix LTI on multi node systems #9085: This PR introduces a new class for managing LTI state in a distributed environment, which could relate to the caching strategy in LearnerProfile.java since both deal with LTI configurations and data management.
• Development: Fix architecture tests for exam deletion summary #9458: The changes in this PR involve modifying access requirements for a method in AdminCourseResource, which may relate to the overall data handling and caching strategies in the application, including those in LearnerProfile.java.

Suggested labels

tests, ready for review

Suggested reviewers

• JohannesStoehr
• krusche
• maximiliansoelch

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e1dec66 and f1981a6.

📒 Files selected for processing (1)

• gradle/jacoco.gradle (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: client-style
• GitHub Check: client-tests
• GitHub Check: server-tests
• GitHub Check: server-style
• GitHub Check: Build and Push Docker Image
• GitHub Check: Build .war artifact
• GitHub Check: Analyse

🔇 Additional comments (2)

gradle/jacoco.gradle (2)

17-17: Confirm if coverage threshold reduction is temporary.

The reduction in coverage threshold from 0.860 to 0.850 for the atlas module appears reasonable given the removal of caching logic. However, please clarify if this is intended to be a permanent reduction or if there are plans to restore the threshold once the caching changes are stabilized.

---

17-17: Verify coverage impact on similar modules.

Since this change is related to caching behavior modifications, it would be prudent to verify if other modules using similar caching patterns might also need coverage threshold adjustments.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.