Update README.md #295
Merged
Update README.md #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve cmake section in README
FG-TUM
reviewed
Mar 7, 2024
FG-TUM
reviewed
Mar 7, 2024
FG-TUM
previously approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Overall I'm fine with the changes, but if you are really motivated to give this some polish I think we should focus less on "here are 5 alternatives to do X" and focus more on one way:
mkdir build
cd build
CC=clang CXX=clang++ ccmake ..
make -j $(nproc)Meaning maybe shorten the core explanations a bit to the essence.
FG-TUM
previously approved these changes
Mar 20, 2024
see issue #297 for details
FG-TUM
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
cmakesection in the README.md file was revised and updated. A list of compiler commands was added for easy lookup.As
cmakeis the recommended way of building, its position was changed to be before the instructions regardingmake.