adapted elbas gem to handle private-IP-hostnames #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lserman
reviewed
Oct 27, 2022
lib/elbas/aws/instance_collection.rb
Outdated
| @@ -8,7 +8,7 @@ class InstanceCollection < Base | |||
| def initialize(ids) | |||
| @ids = ids | |||
| @instances = query_instances_by_ids(ids).map do |i| | |||
| Instance.new(i.instance_id, i.public_dns_name, i.state.code) | |||
| Instance.new(i.instance_id, i.public_dns_name.present? || i.private_ip_address, i.state.code) | |||
There was a problem hiding this comment.
I think you want presence here, since present? will return a boolean as far as I know 🤔
|
Hello, wow, this is a blast from the past! I don't know much about how AWS deployments are working these days. What is the use case for private IP and will this change affect existing users in any way? Perhaps there are users who have instances without public IPs that are currently being ignored by this gem. If they have private IPs though, wouldn't this change how the gem functions for them? Maybe the inclusion of private IPs can be a configuration option, or maybe the list of instances can be completely overridable by a configuration lambda that receives the instance list and returns which ones should be included. |
…age in the capistrano boot order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted the instance collection to take the hostnames of both public OR private Hostnames