Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42278: Add band constraints to step 1, step 5 HSC-RC2 weekly reprocessing defaults #37

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

eigerx
Copy link
Contributor

@eigerx eigerx commented Jan 24, 2024

No description provided.

@eigerx eigerx changed the title Add band constraints to step 1, step 5 HSC-RC2 weekly reprocessing defaults DM-42278: Add band constraints to step 1, step 5 HSC-RC2 weekly reprocessing defaults Jan 24, 2024
@eigerx eigerx requested a review from kherner January 24, 2024 00:32
Copy link

@kherner kherner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other random comment: There are several things that yamllint is flagging (mostly true vs. True), including a couple of missing space things. I defer to the developer guide on what the right things to do is there.

@@ -40,7 +40,7 @@ step1:
prerequisites: []
includes: ["step"]
pipeline_yaml: "${DRP_PIPE_DIR}/pipelines/HSC/DRP-RC2.yaml#step1"
data_query_base: "instrument = 'HSC' and skymap = 'hsc_rings_v1'"
data_query_base: "instrument = 'HSC' and skymap = 'hsc_rings_v1' AND band IN ('g','r','i','z','y')"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor point, but you have "and" in one case but "AND" in the next one; probably want to standardize.

@@ -90,7 +90,7 @@ step5:
prerequisites: ["step4"]
includes: ["step"]
pipeline_yaml: "${DRP_PIPE_DIR}/pipelines/HSC/DRP-RC2.yaml#step5"
data_query_base: "instrument = 'HSC' and skymap = 'hsc_rings_v1'"
data_query_base: "instrument = 'HSC' and skymap = 'hsc_rings_v1' AND band IN ('g','r','i','z','y')'"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here.

@eigerx eigerx merged commit c8ee5f7 into main Jan 24, 2024
5 checks passed
@eigerx eigerx deleted the tickets/DM-42278 branch January 24, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants