DM-46747 refactor pqserver per SQR-072 #65
Conversation
bbrondel
force-pushed
the
tickets/DM-46747
branch
from
6f6d5e9 to
09e4ecc
Compare
bbrondel
force-pushed
the
tickets/DM-46747
branch
from
09e4ecc to
b402b60
Compare
|
|
||
| instrument = instrument.lower() | ||
| logger = logging.getLogger() | ||
| engine = get_engine() |
There was a problem hiding this comment.
Why not have this as a parameter and def get_instrument_table(..., engine = Depends(get_engine)):
|
|
||
|
|
||
| def get_instrument_list(): | ||
| global instrument_list |
There was a problem hiding this comment.
In this case I think instrument_list should be a parameter.
python/lsst/consdb/dependencies.py
Outdated
| def validate_instrument_name( | ||
| instrument: str = Path(description="Must be a valid instrument name (e.g., ``LATISS``)"), | ||
| ) -> str: | ||
| print(f"validate_instrument_name({instrument=})") |
There was a problem hiding this comment.
Please remove some print statements or turn them into logging when this is not 'draft'
| ) | ||
|
|
||
| # Check SQLAlchemy version | ||
| required_version = (2, 0, 0) |
There was a problem hiding this comment.
Maybe we could put this in our requirements.txt or something?
There was a problem hiding this comment.
I've removed the version check from the code, but I think setting up requirements.txt or similar calls for a new ticket. The needs of consdb are fairly complicated given that there are several products coming from this repository.
There was a problem hiding this comment.
If you wanted to add requirements on such a major refactoring, that seems fine - I don't see that needing its own ticket.
Co-authored-by: Valerie <[email protected]>
This divides the functionality in pqserver into separate units. It also switches from using a
Connectionobject toSessionobjects so that sqlalchemy is managing a connection pool.Note that the error behavior is not preserved by this change. My impression is that no one is relying on the existing error behavior, so it is to our advantage to move to error formats that are provided by FastAPI.