DM-42469: Update fan-out for the nextVisit schema change #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
force-pushed
the
tickets/DM-42469
branch
4 times, most recently
from
351eb8d to
59cba21
Compare
kfindeisen
approved these changes
Jan 16, 2024
Comment on lines
288
to
297
| latiss_gauge.inc() | ||
| fan_out_message_list = ( | ||
| next_visit_message_updated.add_detectors( | ||
| "LATISS", | ||
| dataclasses.asdict(next_visit_message_updated), | ||
| latiss_active_detectors, | ||
| ) |
There was a problem hiding this comment.
It seems a bit odd to have add_detectors be triggered by a match on salIndex when we're already assuming that next_visit_message_updated has a valid instrument. Is this to handle the weird edge case of upload.py HSC? If so, it might be a good idea to add a comment to the match block.
There was a problem hiding this comment.
Now that we have a valid instrument we probably can refactor this. Indeed the weird case of upload.py HSC incomplete detectors will make the refactoring uglier. I'll add a comment.
The field "instrument" was added to the schema of summit nextVist messages. Therefore the fan-out service no longer needs to add the "instrument" field to the fanned-out messages.
hsinfang
force-pushed
the
tickets/DM-42469
branch
from
59cba21 to
4906253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.