Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48416: Declare isr in pipeline before referencing it #305

Merged
merged 6 commits into from
Jan 15, 2025
Merged

DM-48416: Declare isr in pipeline before referencing it #305

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d328a1c
Declare isr in pipeline before referencing it
mfisherlevine Jan 14, 2025
fdb2e58
Use ISR configs from comcam commissioning as default
jbkalmbach Jan 14, 2025
a6cf674
Add tests for production pipelines
mfisherlevine Jan 15, 2025
39c23d2
Add aggregateDonutTablesTask to donutVizGroupPipeline definition
mfisherlevine Jan 15, 2025
492f997
Update .gitignore for new packaging system
mfisherlevine Jan 15, 2025
c281c8f
Fix ComCamSim pipeline.
jbkalmbach Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/versionHistory.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@
Version History
##################

.. _lsst.ts.wep-13.3.1:

-------------
13.3.1
-------------

* Add isr configs back into default pipelines.

.. _lsst.ts.wep-13.3.0:

-------------
Expand Down
13 changes: 13 additions & 0 deletions pipelines/_ingredients/wepDirectDetectScienceGroupPipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
description: wep direct detect pipeline

tasks:
isr:
class: lsst.ip.isr.IsrTaskLSST
config:
# Although we don't have to apply the amp offset corrections, we do want
# to compute them for analyzeAmpOffsetMetadata to report on as metrics.
doAmpOffset: true
ampOffset.doApplyAmpOffset: false
# Turn off slow steps in ISR
doBrighterFatter: false
# Mask saturated pixels,
# but turn off quadratic crosstalk because it's currently broken
doSaturation: True
crosstalk.doQuadraticCrosstalkCorrection: False
generateDonutDirectDetectTask:
class: lsst.ts.wep.task.generateDonutDirectDetectTask.GenerateDonutDirectDetectTask
config:
Expand Down
Loading