DM-41832: Use spawn as start method, deprecate fork option #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork became unusable, switching default start method to spawn. Forkserver option is still available, fork option is kept in CLI for compatibility but we issue a warning and switch to spawn if fork is given.
andy-slac
force-pushed
the
tickets/DM-41832
branch
from
34aa884 to
15c9426
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
- Coverage 87.21% 87.14% -0.07%
==========================================
Files 49 49
Lines 4419 4427 +8
Branches 762 764 +2
==========================================
+ Hits 3854 3858 +4
- Misses 407 413 +6
+ Partials 158 156 -2 ☔ View full report in Codecov by Sentry. |
timj
approved these changes
Nov 22, 2023
| @@ -393,11 +395,9 @@ def __init__( | |||
| self.executionGraphFixup = executionGraphFixup | |||
| self.report: Report | None = None | |||
|
|
|||
| # We set default start method as spawn for MacOS and fork for Linux; | |||
| # None for all other platforms to use multiprocessing default. | |||
There was a problem hiding this comment.
Is fork the multiprocessing default then?
There was a problem hiding this comment.
Fork is default for Linux, spawn is default for MacOS and Windows.
Co-authored-by: Tim Jenness <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork became unusable, switching default start method to spawn. Forkserver
option is still available, fork option is kept in CLI for compatibility
but we issue a warning and switch to spawn if fork is given.
Checklist
doc/changes