Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47730: add "success caveats" system to report on NoWorkFound and similar cases #320

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Jan 15, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (f3af793) to head (d771db7).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/ctrl/mpexec/cli/script/report.py 58.33% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   89.98%   90.16%   +0.18%     
==========================================
  Files          50       50              
  Lines        4572     4626      +54     
  Branches      421      426       +5     
==========================================
+ Hits         4114     4171      +57     
+ Misses        330      325       -5     
- Partials      128      130       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge approved.

@TallJimbo TallJimbo merged commit 1d9d8a2 into main Jan 21, 2025
16 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-47730 branch January 21, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants