DM-44352: Add subtask to build camera from astrometric model #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
force-pushed
the
tickets/DM-44352
branch
from
7b757ef to
95fdc00
Compare
cmsaunders
changed the title
cmsaunders
force-pushed
the
tickets/DM-44352
branch
from
8e9bda2 to
f2f417c
Compare
PFLeget
reviewed
Sep 12, 2024
| for k, params in mapParams.items(): | ||
| if re.fullmatch(visitTemplate, k): | ||
| visitParams.append(params) | ||
| identityVisitParams = np.array([0, 1, 0, 0, 0, 1]) |
There was a problem hiding this comment.
For my personal understanding why this is like this?
There was a problem hiding this comment.
This is an array of coefficients that correspond to the c terms in x' = c_{0} + c_{1} x + c_{2} y and y' = c_{3} + c_{4} x + c_{5} y, meaning that this transform will give x' = x and y' = y.
In gbdes, in order to break degeneracies, one of the visits gets picked to have an Identity map for the per-visit, so I have to add that in here, along with the map parameters that are actually fit.
PFLeget
approved these changes
Sep 12, 2024
cmsaunders
force-pushed
the
tickets/DM-44352
branch
from
3b07144 to
17ae3be
Compare
cmsaunders
force-pushed
the
tickets/DM-44352
branch
2 times, most recently
from
88445bc to
7a91bfa
Compare
cmsaunders
force-pushed
the
tickets/DM-44352
branch
from
7a91bfa to
fe2ce30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.