Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Postgres 16 DP02 butler SQL on data-int #552

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Jan 15, 2025

Add Postgres 16 DB for the DP02 Butler to data-int. Moved some configuration out of the tfvars file into the defaults so it can be shared between all the environments.

Also added domain names that can be used for referencing the databases from Phalanx configuration.

Added a 'moved' block to prevent terraform from destroying the data-dev DB. The terraform code for this DB had changed since data-dev was last deployed.

@dhirving dhirving force-pushed the tickets/DM-45901a branch 5 times, most recently from c82ea74 to 2d2d5e6 Compare January 15, 2025 22:19
@dhirving dhirving marked this pull request as ready for review January 15, 2025 22:27
@dhirving dhirving requested a review from dspeck1 January 15, 2025 22:30
@dhirving
Copy link
Contributor Author

@dspeck1 If you're able to review this, I'd like to get this merged so I can finish setting up this database.

For DP02 SQL configuration that is expected to be identical on all three environments, use the default value specified in variables.tf instead of explicitly specifying it in each configuration.  This will make it easier to keep the configuration in sync.
Add a private DNS name for the DP02 Cloud SQL instance to the VPC, so we don't have to hard-code IP addresses in configuration.
Copy link
Collaborator

@dspeck1 dspeck1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhirving dhirving merged commit fc82953 into main Jan 21, 2025
3 checks passed
@dhirving dhirving deleted the tickets/DM-45901a branch January 21, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants