Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47165: Update astrom/photoCal for early ComCam data. #569

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

ctslater
Copy link
Member

No description provided.

("r", "monster_SynthLSST_r"),
("i", "monster_SynthLSST_i"),
("z", "monster_SynthLSST_z"),
("y", "monster_SynthLSST_y"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the time being we want to have both here, or we can fix this when we fix the photoCal code which is fundamentally broken because it uses band if colorTerms are off and uses filter if colorTerms are on and that's insane. I think the RFC was about cleaning that up, but it's definitely wrong at the moment (by definition). If we want to calibrate empty/white the lines should be:

    ("empty", "monster_SynthLSST_r"),
    ("white", "monster_SynthLSST_r"),

(One for filter, the other for band).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if we are never photocalibrating empty those can be left off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, I'll add all-of-the-mappings for now and I left a note with your explanation why and the RFC.

@@ -3,3 +3,9 @@
obsConfigDir = os.path.join(os.path.dirname(__file__))
config.photoRefObjLoader.load(os.path.join(obsConfigDir, "filterMap.py"))
config.connections.astromRefCat = "the_monster_20240904"

# Loosen maxOffset to account for early pointing model inaccuracy.
config.astrometry.matcher.maxOffsetPix=500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you note the comment about also updating LoadReferenceObjectsConfig.pixelMargin in the docstring for that config:

    maxOffsetPix = pexConfig.RangeField(
        doc="Maximum allowed shift of WCS, due to matching (pixel). "
            "When changing this value, the "
            "LoadReferenceObjectsConfig.pixelMargin should also be updated.",
        dtype=int,
        default=250,
        max=4000,
    )

Also, I think the padding in for the visit definition may need to be considered if things are really bad:
https://github.com/lsst/obs_base/blob/2b7fa98c38048493aa6c69f9e8fa92a242ee93f2/python/lsst/obs/base/defineVisits.py#L276-L289

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Added config.astromRefObjLoader.pixelMargin=500 for consistency,

@ctslater ctslater force-pushed the tickets/DM-47165 branch 2 times, most recently from a47c9f1 to bab376a Compare October 27, 2024 23:03
@ctslater ctslater merged commit 2f81eaf into main Oct 27, 2024
3 checks passed
@ctslater ctslater deleted the tickets/DM-47165 branch October 27, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants