DM-47303: Add fgcmcal configurations for LSSTComCam #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-47303
branch
from
3c14321 to
40065e0
Compare
sr525
reviewed
Nov 20, 2024
|
|
||
| config.outfileBase = "fgcmLSSTComCam" | ||
| config.bands = ["u", "g", "r", "i", "z"] | ||
| config.fitBands = ["u", "g", "r", "i", "z"] |
There was a problem hiding this comment.
We don't support y band yet. All the stuff below is a placeholder.
sr525
reviewed
Nov 20, 2024
config/comCam/fgcmFitCycle.py
Outdated
| } | ||
| config.autoPhotometricCutNSig = 3.0 | ||
| config.autoHighCutNSig = 3.0 | ||
| # Fit aperture corrections with only 2 bins to exercise the code. |
There was a problem hiding this comment.
Is this comment relevant still?
sr525
reviewed
Nov 20, 2024
| "r": fgcmcal.Sedterm(primaryTerm="gr", secondaryTerm="ri", constant=0.9), | ||
| "i": fgcmcal.Sedterm(primaryTerm="ri", secondaryTerm="iz", constant=1.1), | ||
| "z": fgcmcal.Sedterm(primaryTerm="iz", secondaryTerm="ri", constant=1.0, | ||
| extrapolated=True, primaryBand="z", secondaryBand="i", tertiaryBand="r") |
There was a problem hiding this comment.
Are primary and secondary bands the correct way round?
There was a problem hiding this comment.
Yes, they are. This is start by using the z band and adjust from there. z is primary to the z.
sr525
reviewed
Nov 20, 2024
| # extrapolated=True, primaryBand="y", | ||
| # secondaryBand="z", tertiaryBand="i") | ||
| } | ||
|
|
There was a problem hiding this comment.
Should this still be commented out?
There was a problem hiding this comment.
We can uncomment when it supports y band. I added a comment.
sr525
reviewed
Nov 20, 2024
| "y": False, | ||
| } | ||
| config.sigFgcmMaxEGrayDict = { | ||
| "u": 0.15, |
There was a problem hiding this comment.
Is this one supposed to be different to the others?
There was a problem hiding this comment.
Yes! Comment added.
erykoff
force-pushed
the
tickets/DM-47303
branch
from
34946af to
d9b1d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports ugriz so far.