Skip to content

Commit

Permalink
Merge pull request #25 from lsst/tickets/DM-29613
Browse files Browse the repository at this point in the history
DM-29613: Replace outdated /oauth2 endpoints with /login, /logout
  • Loading branch information
gpdf authored Apr 7, 2021
2 parents dd2e29f + 34f1a0f commit a9ee586
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 9 deletions.
13 changes: 11 additions & 2 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,20 @@
Change log
##########

2.1.1 (2021-04-07)
==================

- **Uses Firefly release-2020.3.3** See the `Firefly release notes <https://github.com/Caltech-IPAC/firefly/blob/dev/docs/release-notes.md>`. Key LSST-relevant fix:

- Charts in "expanded mode" do not update after options changes
[`FIREFLY-525 <https://jira.ipac.caltech.edu/browse/FIREFLY-525>`_]

- Changes URLs for interaction with the authentication to use Gafaelfawr ones.

2.1.0 (2020-10-05)
==================

- **Uses Firefly release-2020.3.0** See the `Firefly release notes <https://github.com/Caltech-IPAC/firefly/blob/dev/docs\
/release-notes.md>`. Key LSST-relevant features:
- **Uses Firefly release-2020.3.0** See the `Firefly release notes <https://github.com/Caltech-IPAC/firefly/blob/dev/docs/release-notes.md>`. Key LSST-relevant features:

- Bug fixes for Python-driven plotting and Slate

Expand Down
4 changes: 2 additions & 2 deletions config/app.config
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ pct.vis.shared.mem.size = 0.4
download.bundle.maxbytes = 304857600

sso.server.url = "https://test.cilogon.org/"
sso.login.url = "oauth2/start?rd=/portal/suit/"
sso.logout.url = "/oauth2/sign_in"
sso.login.url = "/login?rd=/portal/suit/"
sso.logout.url = "/logout"
sso.user.profile.url =
__$help.base.url = "onlinehelp/"

Expand Down
2 changes: 1 addition & 1 deletion config/firefly_build.tag
Original file line number Diff line number Diff line change
@@ -1 +1 @@
rc-2020.3
release-2020.3.3
2 changes: 1 addition & 1 deletion config/k8s/suit-int.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ metadata:
proxy_set_header X-Forwarded-Proto https;
proxy_set_header X-Forwarded-Port 443;
proxy_set_header X-Forwarded-Path /portal/app;
error_page 403 = "https://lsst-lsp-int.ncsa.illinois.edu/oauth2/start?rd=$request_uri";
error_page 403 = "https://lsst-lsp-int.ncsa.illinois.edu/login?rd=$request_uri";
spec:
tls:
- hosts:
Expand Down
2 changes: 1 addition & 1 deletion config/k8s/suit-stable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ metadata:
proxy_set_header X-Forwarded-Proto https;
proxy_set_header X-Forwarded-Port 443;
proxy_set_header X-Forwarded-Path /portal/app;
error_page 403 = "https://lsst-lsp-stable.ncsa.illinois.edu/oauth2/start?rd=$request_uri";
error_page 403 = "https://lsst-lsp-stable.ncsa.illinois.edu/login?rd=$request_uri";
spec:
tls:
- hosts:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
*/
public class LsstSsoAdapter implements SsoAdapter {
private static Logger.LoggerImpl LOGGER = Logger.getLogger();
private static String LOGIN_URL = AppProperties.getProperty("sso.login.url", "/oauth2/start?rd=/portal/suit/");
private static String LOGOUT_URL = AppProperties.getProperty("sso.logout.url", "/oauth2/sign_in");
private static String LOGIN_URL = AppProperties.getProperty("sso.login.url", "/login?rd=/portal/suit/");
private static String LOGOUT_URL = AppProperties.getProperty("sso.logout.url", "/logout");
private static String REQ_AUTH_HOSTS = AppProperties.getProperty("sso.req.auth.hosts", ".ncsa.illinois.edu");

private static final String ID_TOKEN = "X-Auth-Request-Token";
Expand Down

0 comments on commit a9ee586

Please sign in to comment.