DM-41904: Enable python 3.12 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 46 46
Lines 3180 3185 +5
=======================================
+ Hits 2999 3004 +5
Misses 181 181 ☔ View full report in Codecov by Sentry. |
smptd and chunk are deprecated in various python versions. Keep smptd for python 3.9 since wave does not correctly import a version on that platform.
timj
force-pushed
the
tickets/DM-41904
branch
from
37844ca to
7696f57
Compare
utcnow is deprecated in python 3.12 and they want you to use now(datetime.UTC). For older python versions stick with utcnow().
timj
force-pushed
the
tickets/DM-41904
branch
from
9cde193 to
73997de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes