-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-48430: Add ability to get all installed packages from system #198
Conversation
@kfindeisen can you give this a try please? One thing that might be an issue is that the "include_all" option historically includes all the EUPS build numbers. I'm not sure what my motivation for adding that was in #117 but it's an easy fix to remove the tags if we decide they get in the way. |
Reading the Jira ticket I think @mfisherlevine wanted the weekly tag to show up in the version history. The problem is that it also reports build tags:
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 94.15% 94.19% +0.03%
==========================================
Files 47 47
Lines 3440 3463 +23
==========================================
+ Hits 3239 3262 +23
Misses 201 201 ☔ View full report in Codecov by Sentry. |
300f5d9
to
bd6c905
Compare
Well, it is faster (0.5 s vs. 2.1 s on S3DF). I'm not sure how to test its robustness, though -- I can't run PP without a container, and the I didn't see any build numbers in testing. |
As ugly as the build tags are there, I don't think I have anything that relies on the weekly being there alone, and if I need it, I can always try adding a regex of some sort, so I think that's fine (at least for me). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit concerned about the new unit test for fromSystem
, since it requires the exact opposite of what the documentation says. Which is the intended behavior?
Also, please document the new features and bugfixes in doc/changes
.
There has long been 2 variants for this function so a cache size of two makes more sense.
This will be used by a future commit.
bd6c905
to
1a9053d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better, thanks! I won't speculate on why there are now 14 commits instead of a handful.
Thanks. I'll squash a bit now that we got agreement on the approach. |
75fe91a
to
b1fd8eb
Compare
Solely checks that True and False raise no errors.
This reports the versions of all installed python distributions. getPythonPackages only reported python distributions where some code has been imported.
This lets the test check for difference and missing without having to know that a new import can be made.
b1fd8eb
to
f0fe60a
Compare
Checklist
doc/changes