DM-48600: Add helper function for parsing metadata added by timeMethod #199
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 94.19% 94.21% +0.02%
==========================================
Files 47 47
Lines 3463 3476 +13
==========================================
+ Hits 3262 3275 +13
Misses 201 201 ☔ View full report in Codecov by Sentry. |
isullivan
force-pushed
the
tickets/DM-48600
branch
4 times, most recently
from
fda5220 to
6d67ac0
Compare
isullivan
force-pushed
the
tickets/DM-48600
branch
3 times, most recently
from
dae3749 to
37d54e2
Compare
python/lsst/utils/timer.py
Outdated
| @@ -480,3 +479,33 @@ def profile(filename: str | None, log: LsstLoggers | None = None) -> Iterator[cP | |||
| profile.dump_stats(filename) | |||
| if log is not None: | |||
| log.info("cProfile stats written to %s", filename) | |||
|
|
|||
|
|
|||
| def durationFromTimeMethod( | |||
There was a problem hiding this comment.
Please use underscores in names and variables for new functions in this package.
There was a problem hiding this comment.
@timj Since this is a helper function that works with the results of timeMethod, is the name duration_from_timeMethod OK, or should I just change it to something like calculate_duration?
There was a problem hiding this comment.
I can live with duration_from_timeMethod. I should have fixed up the name timeMethod years ago when I migrated the code to the new location. I've been trying to think of other ways to organize this but we are sort of stymied by the historical baggage of timeMethod not knowing what it's updating and so there not being an obvious class that could have this functionality -- TaskMetadata itself is hamstrung by it having to originally be a PropertySet, whereas if we were doign this now we'd have dedicated facilities in TaskMetadata for task execution metadata.
isullivan
force-pushed
the
tickets/DM-48600
branch
from
37d54e2 to
25533b7
Compare
Checklist
doc/changes