Add treesitter highlighting support in cat mode #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve treesitter highlighting metadata to syntax_id needed by nvim_get_hl() in group2ansi() which converts highlighting colours to ANSI escape sequences. Fallback to parsing traditional highlighting if treesitter metadata is not available. This also resolves the issue with no syntax highlighting available at all when treesitter highlighting is active, traditional and treesitter modes are mutually exclusive; that is no traditional highlighting data will be available if treesitter is active for a given buffer. Testing done: * Observed regular and new functionality displaying C and Bash source files in cat mode in traditional highlighting then with treesitter highlighting. * Confirmed that syntax highlighting colours while in treesitter mode match in side by side comparison between nvimpager in cat mode and nvim edit mode.
|
Thanks for the PR! I don't have time to review it until next week but until then you could try to find out why and how the output changed to fix the test. PS and can we make a test case for treesitter highlighting specifically? |
|
Tested on local, works like charm. Will it get merged any time soon? |
|
@night0721 I am currently thinking about how to fix the tests because neovim 0.10 changed the default colorscheme and the tests depend on it. So I am not working on it. I am still hoping for @adeg to come back to this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve treesitter highlighting metadata to syntax_id needed by nvim_get_hl() in group2ansi() which converts highlighting colours to ANSI escape sequences. Fallback to parsing traditional highlighting if treesitter metadata is not available.
This expected to provide functionality requested in #63.
This also resolves the issue with no syntax highlighting available at all when treesitter highlighting is active as traditional and treesitter modes are mutually exclusive; that is no traditional highlighting data will be available if treesitter is active for a given buffer.
Note that a workaround had to be introduced for the treesitter highlighting mode which removes background colour definition for the "Normal" highlight group.
The reason is that treesitter themes seem to define the window background in in the Normal highlight group profile, which was causing spotty background issues with nvimpager rendering a different background for the parts of the text we didn't have a highlighting group for.
Testing done: