improvement: provide extra package for jre-native and jdk, jdk-native #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Van Elsuve <[email protected]>
|
Hi @sebveit, Does this PR is ok for you, or do you have some remark ? |
|
I'm going to look into this PR on friday. Sry for the delay! |
|
I don't know why GitHub Workflow isn't working on your pull requests. Maybe you could check on your fork under settings, if you need to authorize it somehow? Nevertheless, your PR looks nice! Only things I have spotted is that the contents of I'm going to test the native JDK recipe of this PR with a recipe, that compiles a simple hello world, next week. If that works, I'm merging your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
providing extra package on the bases of pre build version for jdk-21 and jdk-21-native