Code refactoring and enhancement #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork info
…he code (2) Allow for command line arguments (source and destination directory) (3) use readline-sync instead of readline (4) Create separate Logseq pages instead of Journal pages (5) Use page tags and timestamps (6) Some bulletpoint cleanup (author's individual need) (7) Rename page files with slashes in the title
…he code (2) Allow for command line arguments (source and destination directory) (3) use readline-sync instead of readline (4) Create separate Logseq pages instead of Journal pages (5) Use page tags and timestamps (6) Some bulletpoint cleanup (author's individual need) (7) Rename page files with slashes in the title
Removing a change unneeded for pull req
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @lugenx !
Thank you for your script, it is helping me a lot in Keep -> Logseq migration!
As I needed some adjustments for my purpose, I also tried to split the code into separate functions and enhance it by some new features. Main changes are:
(1) Split the two original functions into separate functions, rewrite the code
(2) Allow for command line arguments (source and destination directory)
(3) Use
readline-syncinstead ofreadline(4) Create separate Logseq pages instead of Journal pages
(5) Use page tags and timestamps
(6) Some bullet point cleanup (just for my particular purpose)
(7) Rename page files with slashes in the title (replace with
___)If you would be interested, we could cooperate to make the script more useful for the folks out there. E.g. we could offer both options - journals and pages, with a possibility to select between them.
Let me know what you think, and if you would like the code committed back to your repo.
Regards!
PS. I am not a professional developer, and this is actually my first pull request on Github, so please correct me if I'm doing something wrong.