Use smooth duty universally #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no objections. The added delay is minimal (12ms), we could even be a bit more aggressive with the smoothing, like 0.95/0.05, without any downsides I can think of |
Duty cycle can spike a lot, the purposes it's used for can all benefit from the mild smoothing we already have. Unify the usage and only use smooth duty for everything.
lukash
force-pushed
the
feature/smooth-duty
branch
from
7f82603 to
a42ac33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duty cycle can spike a lot, the purposes it's used for can all benefit from the mild smoothing we already have. Unify the usage and only use smooth duty for everything.
@surfdado putting this into a PR so that you have a chance to comment, WDYT? The motivation is smoother duty for the haptic duty alert (I had some spikes trigger it during normal riding). Please add a review if you don't mind.
Untested at the time of posting the PR, I'll only merge after I test it, but it's basically just the duty pushback and the wheelslip detection that uses the duty value.