Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Wheelslip timer exit to be more strict #28

Conversation

NicoAleman
Copy link
Contributor

  • Made Wheelslip timer reset condition and exit condition more strict, as to decrease the likelihood of lingering false positives (which prevent alerts like haptic buzz)
  • This should preferably be reverted in the future, with instead a sufficient additional exit condition option, such as looking at power, or speed delta prior to wheelslip
  • Also added duty_raw

Add back duty_raw for the check.
@lukash lukash force-pushed the v1.1-preview2-devel1-wheelslip branch from f432532 to e10f880 Compare December 8, 2024 23:01
@lukash lukash merged commit 5318fd0 into lukash:v1.1-preview2-devel1 Dec 8, 2024
1 check passed
@NicoAleman NicoAleman deleted the v1.1-preview2-devel1-wheelslip branch December 9, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants