Simple-start improvements #29
Conversation
There was a problem hiding this comment.
The git trailer in your commit message doesn't work like this, git requires no newlines between trailers (I got bitten by this before, and with the amount of stuff piling up it's gonna be hard noticing a changelog line is missing):
Feature: More tolerant simple-start implementation with 1 second grace period
Signed-off-by: Dado Mista <[email protected]>
Why do you use the Signed-off-by: one? It actually really only has meaning for the Linux kernel code and maybe few other repos where the owners assign a meaning to it. I mean maybe we could do that, I'm not sure it's necessary, I'd need to read up more on the legal stuff...
But most projects don't use it AFAIK 🤷
| @@ -409,6 +409,9 @@ static void reset_runtime_vars(data *d) { | |||
| d->last_yaw_angle = 0; | |||
| d->yaw_aggregate = 0; | |||
|
|
|||
| // Reset engage_timer (keeps track of how long the board has been engaged/riding) | |||
There was a problem hiding this comment.
Subjective nitpick: I find this comment to be a bit too much of a:
// add two ones together
int x = 1 + 1;The code is self-explanatory IMO and the comment just mostly adds unnecessary verbosity. I can certainly merge this, just that I tend to remove this kind of comments while refactoring (and just try to keep the important ones).
Simple-start now includes a 1 second grace period before heel lifts get detected. Also the cool-down period after dismounting has been reduced to 2 seconds. Feature: More tolerant simple-start implementation with 1 second grace period
surfdado
force-pushed
the
simple-start
branch
from
9aca3bf to
435bec8
Compare
Simple-start now includes a 1 second grace period before heel lifts get detected. Also the cool-down period after dismounting has been reduced to 2 seconds.
Feature: More tolerant simple-start implementation with 1 second grace period