LEDs: add felony led effect

[acheronfail]

My kids found this effect amusing from the old float package, so I ported it over to this one, too!

[lukash]

Hey, thanks for the PR, I was looking forward to people contributing effects, and nicely written, too.

[lukash]

Apologies for the long turnaround.

I wanted to test this, and then I also thought about LED strips with an odd number of LEDs. The way it is one half of the effect will be longer. What about making the center LED always black to make it symmetric?

Also, feel free to squash the second commit to the first and when making changes just amend the outstanding commit, I don't need to see the differences in separate ones.

Lastly, would you add a line like this to your commit message, it's a git trailer and will ensure automatic changelog item (with an attribution to you):

Feature: Add the Felony LED effect.

Thank you!

[acheronfail]

I wanted to test this, and then I also thought about LED strips with an odd number of LEDs. The way it is one half of the effect will be longer. What about making the center LED always black to make it symmetric?

I have some test footage I can upload here if you'd like. Unfortunately I only have LED strips with even numbers of LEDs, so I can't test out odd variations. But I did like your suggestion, so I implemented it.

Also, feel free to squash the second commit to the first and when making changes just amend the outstanding commit, I don't need to see the differences in separate ones.

Lastly, would you add a line like this to your commit message [...]

Squashed, amended commit message with trailer and rebased on the latest trunk. 🙂

[lukash]

I only have LED strips with even numbers of LEDs, so I can't test out odd variations.

You can test it easily, just configure the strip with one less LED 😀

I'll try to test it myself tonight though.

[acheronfail]

You can test it easily, just configure the strip with one less LED 😀

Of course 🤦‍♂️

I tested it (at a slow speed 0.2) with the strip set to 20 and 19 leds, as well as with different colours. You can see the results in these videos here:

even_green-gold.mp4

odd_red-blue.mp4

[lukash]

Thank you!