Provide pattern info with branch log

lukstafi · Jan 30, 2024 · f0cad53 · f0cad53
1 parent 018360d
commit f0cad53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/ppx_minidebug.ml b/ppx_minidebug.ml
@@ -383,8 +383,9 @@ let debug_case callback ~ret_descr ~ret_typ ~alt_typ kind i { pc_lhs; pc_guard;
       (fun (descr_loc, pat, typ) -> !log_value ~loc ~typ ~descr_loc (pat2expr pat))
       bound
   in
-  (* let message = pat2descr ~default:"__case" pc_lhs in *)
-  let message = "<" ^ kind ^ " -- branch " ^ string_of_int i ^ ">" in
+  let message = pat2descr ~default:"_" pc_lhs in
+  let message = if String.equal message.txt "_" then "" else " " ^ message.txt in
+  let message = "<" ^ kind ^ " -- branch " ^ string_of_int i ^ ">" ^ message in
   let ret_descr =
     match ret_descr with
     | None -> { loc = pc_rhs.pexp_loc; txt = kind ^ "__res" }

diff --git a/test/test_expect_test.ml b/test/test_expect_test.ml
@@ -561,7 +561,7 @@ let%expect_test "%debug_show PrintBox tracking <function>" =
       BEGIN DEBUG SESSION
       "test/test_expect_test.ml":549:11-549:12: <function -- branch 3>
       4
-      "test/test_expect_test.ml":551:11-551:14: <function -- branch 5>
+      "test/test_expect_test.ml":551:11-551:14: <function -- branch 5> x
       -3
     |}]