[LUM-863] Entities fix #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segfaultd
added a commit
that referenced
this pull request
Jan 25, 2024
* [LUM-837] Fee manager revamp (#66) * WIP move fees to pool level * WIP * Fee manager structure fix * Cleaning * Fixed pointers issues * Reset the collected amount after distribution * Update fee distribution * Fixed tests and added validation methods * Code format * Validate pool should also validate the fee takers * Use correct constant for default fee amount * Update keeper_fees.go * Patch the logic to the old way. Fix prize to ensure it's checked over multiple fee takers * Introduce store migration for default fee takers init * Code format * Missing migrator * Fix prize collection to make transfer uniques per fee taker * Validate total amount of fee included in pool operations * Introduce test for fee takers validation * Centralize the fee taker validation --------- Co-authored-by: Fabrice Bascoulergue <[email protected]> * [LUM-863] Entities fix (#67) * Make sure to back save entities * Added migration to fix entities * code format * Format * missing upgrade handler * Handle stucked ibc transfer restoration --------- Co-authored-by: Fabrice Bascoulergue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This pull request is required to fix the issue where an entity is incorrectly patched on ICA channel restore operation
It also add a new case in entity state restore operation
Testing
Testing is intended on public testnet