Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generalize compact interning and fetching #1237

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

arthurpaulino
Copy link
Contributor

Interning/fetching environments and provenances share the same logic, so we can unify their implementations to improve code reusability.

@arthurpaulino arthurpaulino requested review from a team as code owners April 10, 2024 09:26
Interning/fetching environments and provenances share the same logic, so
we can unify their implementations to improve code reusability.
@arthurpaulino arthurpaulino force-pushed the ap/generalize-compact-interning branch from 04c5c7a to 15ac41d Compare April 10, 2024 09:28
@arthurpaulino arthurpaulino enabled auto-merge April 10, 2024 09:58
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the refactor!

@arthurpaulino arthurpaulino added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit bab22ba Apr 15, 2024
11 checks passed
@arthurpaulino arthurpaulino deleted the ap/generalize-compact-interning branch April 15, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants