Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LuxonisML Package Structure #22

Merged
merged 3 commits into from
Jan 15, 2024
Merged

LuxonisML Package Structure #22

merged 3 commits into from
Jan 15, 2024

Conversation

kozlov721
Copy link
Contributor

  • changed the package structure to match luxonis-ml
  • removed the action to autogenerate requirements.txt
    • requirements are now loaded dynamically from requirements.txt and requirements-dev.txt

tersekmatija
tersekmatija approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@tersekmatija tersekmatija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sokovninn
Copy link
Member

LGTM, @kozlov721 have you checked whether the main scripts work after changing the structure?

@kozlov721
Copy link
Contributor Author

LGTM, @kozlov721 have you checked whether the main scripts work after changing the structure?

The main script seems to be working fine

sokovninn
sokovninn approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@sokovninn sokovninn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the main scripts manually, and they work fine.

@sokovninn sokovninn merged commit 329a0b6 into dev Jan 15, 2024
1 check passed
@sokovninn sokovninn deleted the chore/luxonis-ml-structure branch January 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersekmatija tersekmatija tersekmatija approved these changes

@sokovninn sokovninn sokovninn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozlov721 @sokovninn @tersekmatija