Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch annotation #35

Merged
merged 13 commits into from
Feb 23, 2024
Merged

Batch annotation #35

merged 13 commits into from
Feb 23, 2024

Conversation

HonzaCuhel
Copy link
Contributor

This PR includes adding batched annotation.

Some benchmarks (NVIDIA L4 24GB GPU):

  • 1000 images batch size 1: 0.480s
  • 1000 images batch size 2: 0.489s
  • 1000 images batch size 4: 0.504s
  • 1000 images batch size 8 (max): 0.507s

Set the default batch size to 1.

@HonzaCuhel HonzaCuhel changed the base branch from main to dev February 21, 2024 13:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Test Results

  6 files    6 suites   45m 17s ⏱️
 72 tests  30 ✅  42 💤 0 ❌
432 runs  180 ✅ 252 💤 0 ❌

Results for commit a9eb344.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
820 391 48% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
datadreamer/dataset_annotation/image_annotator.py 92% 🟢
datadreamer/dataset_annotation/owlv2_annotator.py 72% 🟢
datadreamer/dataset_annotation/utils.py 40% 🟢
datadreamer/pipelines/generate_dataset_from_scratch.py 44% 🟢
TOTAL 62% 🟢

updated for commit: a9eb344 by action🐍

@sokovninn
Copy link
Member

@HonzaCuhel could you please add missing docstrings and replace annotate() with annotate_batch() in the examples?

@HonzaCuhel
Copy link
Contributor Author

Sure thing, I have forgot about it

@HonzaCuhel
Copy link
Contributor Author

@sokovninn I've updated the example and added the missing docstrings.

kozlov721
kozlov721 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sokovninn sokovninn merged commit e8a9e11 into dev Feb 23, 2024
9 checks passed
sokovninn added a commit that referenced this pull request Mar 2, 2024
@HonzaCuhel @actions-user @sokovninn
Batch annotation (#35)
6cdd2c4 
* Add batch annotation

* Update docs & add test & fix batched annotation

* Change default batch annotation

* Fix annotation tests

* Fix tests

* [Automated] Updated coverage badge

* Update annotation example & docstrings

* Fix formatting

* Fix docstring

* [Automated] Updated coverage badge

* refactor: replace annotate() with annotate_batch()

* feature: replace owlv2 resize

---------

Co-authored-by: Jan Cuhel <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Nikita Sokovnin <[email protected]>
@sokovninn sokovninn deleted the batch-annotation branch March 7, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlov721 kozlov721 kozlov721 approved these changes

@sokovninn sokovninn Awaiting requested review from sokovninn

@tersekmatija tersekmatija Awaiting requested review from tersekmatija

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HonzaCuhel @sokovninn @kozlov721 @actions-user