Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to keep images with no annotation #72

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

HonzaCuhel
Copy link
Contributor

This PR includes:

  • Removing "empty images" (images without any annotation) by default
  • Added ---keep-empty-images flag to disable the removing
  • Added warning about presence of empty images for dataset formats
  • Added logging about removal of empty images
  • Added type annotations to some of the classes in the utils folder
  • Updated docs

Copy link

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1693 1069 63% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
datadreamer/dataset_annotation/slimsam_annotator.py 82% 🟢
datadreamer/pipelines/generate_dataset_from_scratch.py 38% 🟢
datadreamer/utils/base_converter.py 96% 🟢
datadreamer/utils/coco_converter.py 90% 🟢
datadreamer/utils/config.py 100% 🟢
datadreamer/utils/convert_dataset.py 23% 🟢
datadreamer/utils/luxonis_dataset_converter.py 73% 🟢
datadreamer/utils/single_label_cls_converter.py 97% 🟢
datadreamer/utils/yolo_converter.py 79% 🟢
TOTAL 75% 🟢

updated for commit: e6653d9 by action🐍

@sokovninn sokovninn changed the title Add option to keep images with no annotation, by default removing & r… Add an option to keep images with no annotation Nov 12, 2024
Copy link

Test Results

  6 files    6 suites   1h 27m 0s ⏱️
 69 tests  55 ✅ 14 💤 0 ❌
414 runs  326 ✅ 88 💤 0 ❌

Results for commit e6653d9.

@HonzaCuhel HonzaCuhel merged commit c89ca34 into dev Nov 12, 2024
9 checks passed
@sokovninn sokovninn deleted the feat/remove-empty-images branch November 12, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants