Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 Replay node in NN build methods #1214

Open
wants to merge 6 commits into
base: v3_develop
Choose a base branch
from
Open

V3 Replay node in NN build methods #1214

wants to merge 6 commits into from

Conversation

Serafadam
Copy link
Contributor

Adds new overloads for build methods in NN, Detections and SpatialDetection nodes. Also some cosmetic changes

@Serafadam Serafadam marked this pull request as draft January 20, 2025 10:41
@Serafadam Serafadam marked this pull request as ready for review January 20, 2025 13:28
@Serafadam Serafadam requested a review from moratom January 20, 2025 13:34
@moratom moratom requested a review from asahtik January 29, 2025 16:14
moratom
moratom approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@moratom moratom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's just add a few basic tests before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moratom moratom moratom approved these changes

@asahtik asahtik Awaiting requested review from asahtik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Serafadam @moratom