Feature/per node log level setting #1217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moratom
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Not relevant to the PR I think?
There was a problem hiding this comment.
Not sure how these changes got into the PR. Removed a2cfcf8
| @@ -57,4 +57,14 @@ void DeviceNode::run() { | |||
| // } | |||
| } | |||
|
|
|||
| void DeviceNode::setLogLevel(dai::LogLevel level) { | |||
| int64_t myid = id; | |||
| device->setNodeLogLevel(myid, level); | |||
There was a problem hiding this comment.
Even before pipeline.start()? Intentional?
There was a problem hiding this comment.
Yes, setting the log level before starting the pipeline is a feature, not something unintended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality of log-level setting for individual nodes. The functionality added allows us to set log-levels for individual nodes, both before and after starting the pipeline (
pipeline.start()) call.Note that if one sets the
DEPTHAI_LEVELenvironment variable, it will get overridden by the correspondingsetLogLevelmethod call for a node. Moreover, if one sets the log level for the entire device (device.setLogLevel(...)), the per-node log levels get overridden.Thus we have the following hierarchy, where greater means precedence.
DEPTHAI_LEVEL<Node<DeviceAs part of this PR, I have also refactored the test for
log-leveltesting, trying to avoid copy-pasted code.Clickup task: https://app.clickup.com/t/86c1gb36k