Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move switching core dump from depthai_gate to FW #908

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Move switching core dump from depthai_gate to FW #908

merged 4 commits into from
Oct 18, 2023

Conversation

moratom
Copy link
Collaborator

@moratom moratom commented Sep 25, 2023

Expose core dump enable through core.

@moratom moratom requested a review from themarpe September 25, 2023 18:54
themarpe
themarpe requested changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPTHAI_CRASHDUMP=[path/to/location] would likely be prefered, as it addresses 2 things at once (location & enable/disable)

Note on naming - this should be standard (as it can contain vastly different information depending on platform)

@moratom moratom requested a review from themarpe October 16, 2023 11:38
@moratom moratom merged commit cd73f00 into rvc3_develop Oct 18, 2023
2 of 22 checks passed
@moratom moratom deleted the core_dump_to_fw branch October 18, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarpe themarpe Awaiting requested review from themarpe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moratom @themarpe