-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Detection Manip Config Script #164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 35.88% 36.07% +0.19%
==========================================
Files 70 72 +2
Lines 4013 4025 +12
==========================================
+ Hits 1440 1452 +12
Misses 2573 2573 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Basically, just what Klemen and Jakob said. I would also add docstring documenting the function behaviour and explaining parameters. E.g that padding extends the bbox and is used to include the whole object more likely.
Extended the method docs. |
Moving detection manip config script (
generate_script_content
) from DepthAI experiments. Also includes test for the script.