Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detection Manip Config Script #164

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

dominik737
Copy link
Contributor

Moving detection manip config script (generate_script_content) from DepthAI experiments. Also includes test for the script.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.07%. Comparing base (b013402) to head (20ee401).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   35.88%   36.07%   +0.19%     
==========================================
  Files          70       72       +2     
  Lines        4013     4025      +12     
==========================================
+ Hits         1440     1452      +12     
  Misses       2573     2573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some comments

Copy link
Collaborator

@kkeroo kkeroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Basically, just what Klemen and Jakob said. I would also add docstring documenting the function behaviour and explaining parameters. E.g that padding extends the bbox and is used to include the whole object more likely.

@dominik737
Copy link
Contributor Author

Extended the method docs.

@dominik737 dominik737 merged commit 36b31d3 into main Jan 28, 2025
10 of 11 checks passed
@dominik737 dominik737 deleted the feat/detection-manip-config-script branch January 28, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants