Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RVC2 and RVC4 benchmark scripts to work with the dai Benchmark Nodes #64

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ptoupas
Copy link
Contributor

@ptoupas ptoupas commented Jan 9, 2025

  • Updated the RVC2 benchmark to work with dai V3 using the newly added Benchmark Nodes.
    • The new script accepts .blob, .tar.xz, and model slugs from HubAI.
  • Added a second benchmark option to RVC4 to use dai V3 as the way to bechmark the models.
    • The new script accepts .tar.xz, and model slugs from HubAI. It does not accept .dlc files.

Using the dai Benchmark Nodes the latency measurements are not valid in most cases, so this is omitted from the Benchmark reports in the case where the dai benchmark is being used.

@ptoupas ptoupas added the fix Fixes a bug label Jan 9, 2025
@ptoupas ptoupas self-assigned this Jan 9, 2025
@ptoupas ptoupas requested a review from a team as a code owner January 9, 2025 14:07
@ptoupas ptoupas requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team January 9, 2025 14:07
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

modelconverter/utils/hubai_utils.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants