Update docs #410
Update docs #410
Conversation
* Minimal Qt version is bumped in lxqt/lxqt#1844 * Minimal CMake version is bumped in #230 * Closes #402 - confusion around lxqt-build-tools version and PyQt builds
docs/configuration.md
Outdated
| Technically, the background image is no longer blended with the background color. | ||
|
|
||
| Before migrating the settings, the background image should be converted to a translucent one with the transparency level matching the original terminal transparency. | ||
| For example, if the original terminal transparency of qtermwidget was 25%, the converted image should have transparency 25%. |
There was a problem hiding this comment.
I think the above 2 lines may be a little confusing. For example, the terminal transparency can be zero but the user may prefer a very translucent background image. There's no predetermined relationship between image translucency and terminal transparency. It depends on the image and, of course, the user's taste.
Something like this may be better (only as a suggestion):
Any background image can be used but, of course, it should be chosen so that the terminal text can be easily read on it.
Since an image may not be totally dark or light, you might want to use a translucent image as the background. Opaque images can also be converted to translucent ones easily.
There was a problem hiding this comment.
I'd like to provide a clear migration path for the most common existing usage (I assume it is, as many other terminals work that way). How about appending my paragraph after yours as an example?
There was a problem hiding this comment.
How about appending my paragraph after yours as an example?
That would be better.
There was a problem hiding this comment.
Updated, thanks a lot for the suggestion!
|
This may be totally unrelated to the current PR. It's just a suggestion about all future Markdown documents in LXQt. I remember that @agaida told me about line length in plain-text and that it's better to be less than 80/90. 80 may be too small. So, if we want to limit the plain-text line length in our future Markdown docs — which is NOT necessary at all — we could use 90. I don't want to cause headaches about such an unimportant topic. Feel free to ignore it if it's too much. |
|
The line length limit is a good idea. How about mentioning it at lxqt/pcmanfm-qt#550 or some other more visible ticket? |
Yes, we should mention it somewhere. 90 was just a suggestion; some may prefer 100. |
I found 100 still short. I prefer to suggest against long sentences but not forbid them ;) |
Agreed. We don't need a strict rule in this regard. |
|
Thanks for the reviews! I'd like to merge it sooner - I'm afraid I forgot about it before the next release. |
* Update docs * Minimal Qt version is bumped in lxqt/lxqt#1844 * Minimal CMake version is bumped in lxqt#230 * Closes lxqt#402 - confusion around lxqt-build-tools version and PyQt builds * Address comments
builds
@tsujan: I requested a review just as a reminder. This PR is in no hurry. Any time before 0.17 is fine.