-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lib always using cookies #77
Comments
Thx for posting an example. I'll take a look ASAP. |
Thanks a lot ❤️ |
Doing some quick look I found that at >this line the variable The expected value(that I think it is) for the
That would be in the key of |
Actually >in this line user and headers does not exist in the object retrieved in the object called in Is that a bug? |
Also running into this issue. It doesn't seem that Edit: With a bit of hacking, I seem to have got this working in It will now try to validate the token even if https://github.com/lynndylanhurley/redux-auth/blob/master/src/utils/client-settings.js#L94-L114
I haven't tested this at all with SSR. I'm sure it will break things... |
I believe I have the same issue... 👍 for this! |
@hitchcott thanks a lot for helping out! it breaks the code because it's not returning a |
Would it be possible to open a pull request to fix client-side only usage? |
My PR breaks 24 tests. |
Thanks for the contribution @betoharres and thanks for the work on the library @lynndylanhurley. I have also been experiencing this issue in an attempt to rip out home rolled auth in favor of a community driven package. calling configure with the following: return store.dispatch(configure(
{ apiUrl: 'http://localhost:3333' },
{ serverSideRendering: false, cleanSession: true, clientOnly: true }
))
.then(() => ({ store: store, history: browserHistory })) has left me with the name.replace is not a function error. Its strange, the issue is intermittent... Just hoping to draw some attention here to the issue, we are also running in "clientOnly" mode. |
No, not yet, we just did an initial pass through as a research spike. if we get the go ahead to fork and work this I'll definitely use that as a guide to get started. |
I've tried using #86 but am still seeing the errors, for whatever reason. We have had to disable email login in production, and are simply relying on Omniauth at the moment. Hopefully there is a fix in the near future. |
Hello! Thanks for help! |
Cookies are saved from ./src/utils/fetch.js, which you must use in order to do all your ajax requests to the server (the storage logic is in src/utils/session-storage.js). |
Hi, I'm also running into this issue the following way:
I am not logged in yet. Any ideas? Thanks in advance! |
Make sure that you configure CORS properly on the server side to allow for the specific headers such as: ["token-type", "uid", "client", "access-token", "expiry"] |
Faced the things described across several issues in this repo, so to sum up how to use this without server–side rendering, I can advise the following settings to provide in the
Also thanks a lot @betoharres for your fork — but would be great to provide a build changes too (not only source) in your PR #86 |
@sibsfinx Thanks! You mean running |
@betoharres yes, exactly |
Every time I click the link in my email sent by the
desive_token_auth
ruby
gem, it fails throwing an error saying that a variablevalue
in thebrowser-cookies
library in the line 28 is undefined.It happens when I try to confirm an email or reset a password.
I already tested the api using the dummy app and it works fine, but it's working using the server-side rendering configuration, which is not what I need.
I'm trying to get this working and I already went line by line for 2 days in the dummy and demo app in this library and everything seems right.
I'm just asking help because I have no more where to go.
The code I'm working can be found here: https://github.com/betoharres/redux-auth-test
A big thanks for any help here ❤️
The text was updated successfully, but these errors were encountered: