Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support utf-8 #78

Closed
wants to merge 1 commit into from
Closed

Conversation

pcbimon
Copy link

@pcbimon pcbimon commented Jan 13, 2025

sorry for my bad in english. i modify qr-code-styling to add props multibyte to allow UTF-8 and publish from my forks but it's not good practis.

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mini-qr-code-generator ❌ Failed (Inspect) Jan 13, 2025 5:46pm

@@ -31,6 +31,7 @@
"jszip": "^3.10.1",
"lucide-vue-next": "^0.321.0",
"qr-code-styling": "^1.6.0-rc.1",
"qr-code-styling-utf8": "^1.9.4",
Copy link
Owner

@lyqht lyqht Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be ideal to get the an appropriate utf8 fix up on the main qr-code-styling library, and then update its version here rather than having 2 separate qr-code-styling library dependencies.

Reading the kozakdenys/qr-code-styling#62, it also seems possible that you can just encode the string before passing it to the qr-code-styling library to create the QR. Could you give it a try and see if that suffices?

@lyqht lyqht closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants