Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when column name wildcard is prefixed by table name #296

Closed
wants to merge 8 commits into from
Closed

Handle when column name wildcard is prefixed by table name #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3205fc
Handle when column name wildcard is prefixed by table name
sumartoyo Mar 11, 2022
e8d477c
Add test for getting wildcard column with table prefix
sumartoyo Mar 11, 2022
c10151e
Formatting tests
sumartoyo Mar 18, 2022
53160e7
Merge branch 'master' into fix/column-name-wildcard-prefix-table-name
macbre Apr 22, 2022
91b42c2
Merge branch 'master' into fix/column-name-wildcard-prefix-table-name
macbre Apr 24, 2022
98d25ca
Merge branch 'master' into fix/column-name-wildcard-prefix-table-name
macbre Jul 16, 2022
9fa23eb
Merge branch 'master' into fix/column-name-wildcard-prefix-table-name
macbre Aug 2, 2022
dc5a7b1
Merge branch 'master' into fix/column-name-wildcard-prefix-table-name
macbre Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sql_metadata/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,9 @@ def _resolve_nested_query(
# handle case when column name is used but subquery select all by wildcard
if "*" in subparser.columns:
return column_name
for table in subparser.tables:
if f"{table}.*" in subparser.columns:
return column_name
raise exc # pragma: no cover
resolved_column = subparser.columns[column_index]
return [resolved_column]
Expand Down
9 changes: 9 additions & 0 deletions test/test_getting_columns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ def test_getting_columns():
"test",
]
assert Parser("SELECT /* a comment */ bar FROM test_table").columns == ["bar"]
assert (
Parser(
"""
WITH foo AS (SELECT test_table.* FROM test_table)
SELECT foo.bar FROM foo
"""
).columns
== ["test_table.*", "bar"]
)


def test_columns_with_order_by():
Expand Down
Loading