Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/gjp miner #314

Merged
merged 26 commits into from
Jan 27, 2025
Merged

Features/gjp miner #314

merged 26 commits into from
Jan 27, 2025

Conversation

schampoux
Copy link
Contributor

@schampoux schampoux commented Jan 13, 2025

PR created from feature/rqlite-integration branch containing the rqlite read-only node script. This PR adds the following:

  • Updates environment variables to run start_read_node.sh.
  • Adds functions for miners to interact with the global job pool (GJP) snapshot on their local machine. These functions allow miners to select max_workers number of jobs based on priority, or directly specify the pdb_id to select only one job. They can also choose specific columns that they would like to fetch. Lastly, miners can download the input and output files of selected jobs for analysis.
  • Updates instructions in README.md for the above information.

Copy link
Contributor

@mccrindlebrian mccrindlebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

@schampoux schampoux marked this pull request as ready for review January 17, 2025 00:22
Copy link
Contributor

@mccrindlebrian mccrindlebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, I think it would be also necessary to indicate how to use this table / how to start the rqlite db. If we can do that in either docs or something similar, then I think we can merge to main to allow miners to sample it.

A particular use case is that miners want to be able to pull cpt files of other jobs in a separate script for analysis and comparison. Can you also illustrate this in a scripts/query_rqlite_db.py file? Something simple that shows how to do this effectively

folding/miners/folding_miner.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Sarkosos Sarkosos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sarkosos Sarkosos merged commit e0e8565 into staging Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants