Changes based on Griddy Chain #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.env.example
Outdated
| @@ -81,6 +82,9 @@ MADARA_ORCHESTRATOR_HOST= # Server host | |||
| MADARA_ORCHESTRATOR_PORT= # Server port | |||
|
|
|||
| #### SERVICE #### | |||
|
|
|||
| MADARA_ORCHESTRATOR_UNIQUE_ID= # Unique ID for the orchestrator | |||
|
|
||
| /// The maximum number of SNOS jobs to process concurrently. | ||
| #[arg(env = "MADARA_ORCHESTRATOR_MAX_CONCURRENT_SNOS_JOBS", long)] | ||
| pub max_concurrent_snos_jobs: Option<String>, |
There was a problem hiding this comment.
why not do an optional u64 direcrtly?
| @@ -419,4 +419,34 @@ impl Database for MongoDb { | |||
| ORCHESTRATOR_METRICS.db_calls_response_time.record(duration.as_secs_f64(), &attributes); | |||
| Ok(jobs) | |||
| } | |||
|
|
|||
| #[tracing::instrument(skip(self, limit), fields(function_type = "db_call"), ret, err)] | |||
| async fn get_jobs_by_statuses_and_orchestrator_id( | |||
There was a problem hiding this comment.
if the purpose is to differentiate between pods, I don't think it's a good design as discussed before.
crates/orchestrator/src/jobs/mod.rs
Outdated
| return Ok(true); | ||
| } | ||
|
|
||
| let jobs = config |
There was a problem hiding this comment.
this doesn't need to be stored in the db, we can use a semaphore for this. it's simpler imo
There was a problem hiding this comment.
are these changes needed anymore
* update: added delay between cron rule & creation * update: added min_block_to_process for state_update worker * added: changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOS concurrency control and resource optimization
Core Changes
1. Orchestrator Concurrency Control
MADARA_ORCHESTRATOR_MAX_CONCURRENT_SNOS_JOBS: Controls parallel SNOS jobs per runnerMADARA_ORCHESTRATOR_UNIQUE_ID: Unique identifier for each runner pod2. Job Processing Tracking
3. Consistency Improvements
4. Memory Optimization