fix(comments)

madara-alliance · Oct 21, 2024 · 4af813e · 4af813e
1 parent 05d703c
commit 4af813e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/primitives/transactions/Cargo.toml b/crates/primitives/transactions/Cargo.toml
@@ -33,7 +33,6 @@ starknet_api = { workspace = true }
 
 # Other
 anyhow = { workspace = true }
-lazy_static = { workspace = true }
 log = { workspace = true }
 num-bigint = { workspace = true }
 serde = { workspace = true, features = ["derive"] }

diff --git a/crates/primitives/transactions/src/compute_hash.rs b/crates/primitives/transactions/src/compute_hash.rs
@@ -22,10 +22,8 @@ const L1_HANDLER_PREFIX: Felt = Felt::from_hex_unchecked("0x6c315f68616e646c6572
 
 const L1_GAS: &[u8] = b"L1_GAS";
 const L2_GAS: &[u8] = b"L2_GAS";
-
-lazy_static::lazy_static! {
-    static ref PEDERSEN_EMPTY: Felt = Pedersen::hash_array(&[]);
-}
+const PEDERSEN_EMPTY: Felt =
+    Felt::from_hex_unchecked("0x49ee3eba8c1600700ee1b87eb599f16716b0b1022947733551fde4050ca6804");
 
 impl Transaction {
     pub fn compute_hash(&self, chain_id: Felt, version: StarknetVersion, offset_version: bool) -> Felt {
@@ -77,7 +75,7 @@ impl Transaction {
             Transaction::Declare(_)
             | Transaction::DeployAccount(_)
             | Transaction::Deploy(_)
-            | Transaction::L1Handler(_) => *PEDERSEN_EMPTY,
+            | Transaction::L1Handler(_) => PEDERSEN_EMPTY,
         };
 
         Pedersen::hash(&tx_hash, &signature_hash)
@@ -88,7 +86,7 @@ impl Transaction {
             Transaction::Invoke(tx) => tx.compute_hash_signature::<Pedersen>(),
             Transaction::Declare(tx) => tx.compute_hash_signature::<Pedersen>(),
             Transaction::DeployAccount(tx) => tx.compute_hash_signature::<Pedersen>(),
-            Transaction::Deploy(_) | Transaction::L1Handler(_) => *PEDERSEN_EMPTY,
+            Transaction::Deploy(_) | Transaction::L1Handler(_) => PEDERSEN_EMPTY,
         };
 
         Pedersen::hash(&tx_hash, &signature_hash)
@@ -704,4 +702,9 @@ mod tests {
             Felt::from_hex_unchecked("0x734743d11641ecb3d92bafae091346fec3b2c75f7808e39f8b23d9287636e45");
         assert_eq!(contract_address, expected_contract_address,);
     }
+
+    #[test]
+    fn test_pedersen_empty() {
+        assert_eq!(PEDERSEN_EMPTY, Pedersen::hash_array(&[]))
+    }
 }