added elapsed sync times #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
pushed a commit
that referenced
this pull request
Jan 14, 2025
* update dependencies * update imports * updated changelog * added testcase for bytes conversion * fix clippy error * use zaun for starknet * add simple test for settlement * add sepolia issue * to be fixed: validation error * add madara update state test * use relative path * add ci for settlement client * fix workflow debug * fix workflow debug * add scarb build * ignore flaky test * fix threads issue * add scarb build for madara * check if tool version present * fix workflow debug * fix workflwo * fix directory * should fix it * fix bash command * fix bash command * make scarb installation separate step * use swm action * fix ci path * lint fixed * fix env path for tests * fix lint * remove extra path * try checking structure * check * fix env path * fix the directory * try go into * fix path * remove working directory * final fix * fix: gets triggered multiple times * fix path * fix prettier * change calldata type to (#133) * update workflow * fix lints * Update crates/settlement-clients/starknet/src/tests/test.rs Co-authored-by: Apoorv Sadana <[email protected]> * resolve comments * fix e2e test flow * fix toml lint * Update crates/settlement-clients/starknet/src/tests/test.rs Co-authored-by: Apoorv Sadana <[email protected]> * changed envs * add conversion function and test * remove redundant test * update workflow commit hash * change commit and add prettierignore * nonce implementaion and optimise code * remove coverage bin env * changed to logs * added preset file * update versioned constants path * fix current_path * should do inplace replacement * fix base path * fix final coverage workflow * update preset * change runner * install dependencies * run linter * remove path * reword * change default rust * rerun * install libclang * install more dependencies * install yq * install via snap * install snap first * add y flag * no y flag * enable snapd service * use gh action for yq * yq action * remove working-directory * check env variable * fix ci * remove override in e2e * dotenvy::from_filename * should also build * env override * ignore flaky test * restart ci * enable cargo build * override in starknet client * only starknet * retry running * test settle should work * remove fail fast * update blocktime * change commit * run all tests * resolve comments * added test for get nonce * remove log --------- Co-authored-by: Apoorv Sadana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
Other information