Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping to starknet v0.13.2.1 #244

Merged
merged 3 commits into from
Sep 5, 2024
Merged

bumping to starknet v0.13.2.1 #244

merged 3 commits into from
Sep 5, 2024

Conversation

antiyro
Copy link
Member

@antiyro antiyro commented Sep 4, 2024

bumping the codebase to support v0.13.2.1

TL;DR. Bug-fix for overcharging on class declarations.
Details: v0.13.1.1 versioned constants have 32/1000 but v0.13.2 versioned constants have 875/1000, so 30x more expensive.

will give more infos around it when it compiles

@antiyro antiyro marked this pull request as ready for review September 4, 2024 16:02
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Coverage report

The coverage rate is 67.7155031137332%

0% of new lines are covered.

Diff Coverage details (click to unfold)

crates/primitives/receipt/src/from_blockifier.rs

0.0% of new lines are covered

crates/client/exec/src/block_context.rs

0.0% of new lines are covered

crates/client/mempool/src/lib.rs

0.0% of new lines are covered

@antiyro antiyro requested a review from jbcaron September 4, 2024 16:16
Copy link
Member

@jbcaron jbcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems correct to me

Copy link
Member

@akhercha akhercha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sir

@antiyro antiyro merged commit 25f03ee into main Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants