feat(test): adding JS tests to the CI #284
Conversation
| path: cairo/target | ||
| key: ${{ runner.os }}-cairo-${{ github.sha }} | ||
| fail-on-cache-miss: true | ||
| - name: Setup and run dev chain |
There was a problem hiding this comment.
| - name: Setup and run dev chain | |
| - name: Setup dev chain and run tests |
js_tests/basic.test.ts
Outdated
| await provider.waitForTransaction(declareResponse.transaction_hash); | ||
|
|
||
| // Add assertion to check if the class hash is valid | ||
| expect(declareResponse.class_hash).toBeTruthy(); |
There was a problem hiding this comment.
we should get class hash and see if it's on chain
js_tests/basic.test.ts
Outdated
| ); | ||
|
|
||
| // Add assertion to check if the contract address is valid | ||
| expect(deployResult.contract_address[0]).toBeTruthy(); |
There was a problem hiding this comment.
we can maybe call get class hast at and check if it's registered on chain
js_tests/basic.test.ts
Outdated
| ); | ||
|
|
||
| // Add assertion to check if the account address is valid | ||
| expect(deployResult.contract_address[0]).toBeTruthy(); |
| sudo apt-get update | ||
| sudo apt-get install -y clang llvm libudev-dev protobuf-compiler | ||
| - uses: rui314/setup-mold@v1 | ||
| - uses: software-mansion/setup-scarb@v1 |
There was a problem hiding this comment.
Any reason why you are calling 2 times software-mansion/setup-scarb@v1 for version 2.8.2?
.github/workflows/build.yml
Outdated
| - uses: foundry-rs/foundry-toolchain@v1 | ||
| with: | ||
| version: nightly | ||
| - uses: software-mansion/setup-scarb@v1 |
.github/workflows/build.yml
Outdated
| uses: actions/cache@v3 | ||
| with: | ||
| path: target/release/madara | ||
| key: ${{ runner.os }}-madara-${{ github.sha }} |
There was a problem hiding this comment.
Here it appears that you are generating you key over the commit hash this doesnt invalidate the cache on each commit?
There was a problem hiding this comment.
I have checked maybe you can use:
key: ${{ runner.os }}-madara-${{ hashFiles('Cargo.lock') }}
to generate a key based on the lock changes or take in account even more files
| js_test: | ||
| name: Run JS Tests | ||
| uses: ./.github/workflows/starknet-js-test.yml | ||
| needs: build |
There was a problem hiding this comment.
why does js_test depends on build? could we parallelize that?
There was a problem hiding this comment.
we need a build of madara to have it's instance running before running tests on it
so the flow is that we run madara and we run tests on it, so for that we need the latest build
There was a problem hiding this comment.
could we move the js_tests unde tests/js_tests?
There was a problem hiding this comment.
you mean inside the crates?
There was a problem hiding this comment.
no in the root folder directly, so we can add more tests in the futur
…ly and testing something with coverage as well
Adding starknet js tests
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
No