fix(rpc): estimate fee should throw an error if any txn fails #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiyro
approved these changes
Oct 8, 2024
Trantorian1
requested changes
Oct 8, 2024
| @@ -46,8 +46,16 @@ pub async fn estimate_fee( | |||
|
|
|||
| let execution_results = exec_context.re_execute_transactions([], transactions, true, validate)?; | |||
|
|
|||
| let fee_estimates = | |||
| execution_results.iter().map(|result| exec_context.execution_result_to_fee_estimate(result)).collect(); | |||
| let fee_estimates = execution_results.iter().enumerate().try_fold(Vec::new(), |mut acc, (index, result)| { | |||
There was a problem hiding this comment.
Consider using Vec::with_capacity to avoid unnecessary re-allocation since the max size is known.
Trantorian1
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
estimate_feereturns the estimate even if the txn is failing. This is incorrect andestimate_feeshould fail withTxnExecutionErrorinstead.Pending: add test cases