Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Add testing feature to mc-db dev dependency #295

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Oct 1, 2024

This PR adds the testing mc-db feature to mc-block-import dev-dependencies. This fixes compilation errors when running tests in that crate.

Solves #293.

Pull Request type

Fix

@notlesh
Copy link
Contributor Author

notlesh commented Oct 1, 2024

This CI failure looks unrelated to this PR:

npm warn exec The following package was not found and will be installed: [email protected]
Checking formatting...
[warn] .github/workflows/release.yml
[warn] Code style issues found in the above file. Run Prettier with --write to fix.
Error: Process completed with exit code 1.

@antiyro
Copy link
Member

antiyro commented Oct 2, 2024

This CI failure looks unrelated to this PR:

npm warn exec The following package was not found and will be installed: [email protected]
Checking formatting...
[warn] .github/workflows/release.yml
[warn] Code style issues found in the above file. Run Prettier with --write to fix.
Error: Process completed with exit code 1.

It is probalby due to your changelog format, you can run npx prettier -w . to format it automatically or npx @taplo/[email protected] fmt --config ./taplo/taplo.toml for your cargo format

@antiyro antiyro assigned antiyro and notlesh and unassigned antiyro Oct 2, 2024
@notlesh notlesh force-pushed the notlesh/add_mc_db_testing_to_fix_tests branch from 61a00a8 to 75309b7 Compare October 2, 2024 16:19
@notlesh
Copy link
Contributor Author

notlesh commented Oct 2, 2024

This CI failure looks unrelated to this PR:

npm warn exec The following package was not found and will be installed: [email protected]
Checking formatting...
[warn] .github/workflows/release.yml
[warn] Code style issues found in the above file. Run Prettier with --write to fix.
Error: Process completed with exit code 1.

It is probalby due to your changelog format, you can run npx prettier -w . to format it automatically or npx @taplo/[email protected] fmt --config ./taplo/taplo.toml for your cargo format

I think it was fixed by rebasing main. By the way, I force pushed a rebase rather than add a merge, let me know if that's taboo around here :)

@notlesh notlesh force-pushed the notlesh/add_mc_db_testing_to_fix_tests branch from 75309b7 to 11f96cc Compare October 4, 2024 21:39
@Trantorian1 Trantorian1 merged commit bd185a2 into main Oct 7, 2024
8 of 9 checks passed
@shamsasari shamsasari deleted the notlesh/add_mc_db_testing_to_fix_tests branch October 7, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants